1. 25 Feb, 2022 1 commit
    • Tony Farrell's avatar
      Mostly changes around chase ASI-233, a buffer space issues picked up for... · 471ae956
      Tony Farrell authored
      Mostly changes around chase ASI-233, a buffer space issues picked up for Hector.  Mostly just logging changes.
         Also fixed various spelling issues and removed tab characters
      
       ditscmd.c - When not building for VxWorks, allow for much larger
                                  default reply buffer to avoid stuffing around with
                                 buffer sizes in many cases.
       ditsinteract.c - DitsActionWait()  and called routines.  Add logging  both INTERNAL and USER1 levels.  (ASI-233)
       ditscmd.c - Various places, use USER1 logging level as well as current logging level  (ASI-233)
       ditsuface.c - DitsUfaceTransIdWait - Add logging  both INTERNAL and USER1 levels.  (ASI-233)
       dmakefile - DRAMA version to 3_124.
      471ae956
  2. 14 Oct, 2021 3 commits
  3. 07 Oct, 2021 1 commit
  4. 05 Oct, 2021 1 commit
    • Tony Farrell's avatar
      Includes all the changes from ACMM version 3.119, 3.120, 3.121, 3.122. Since... · 7356c02b
      Tony Farrell authored
      Includes all the changes from ACMM version 3.119, 3.120, 3.121, 3.122.  Since the GIT and ACMM versions had changed indepdently.
      
         ACMM ChangeLog: Wed May 05 14:18:14 2021 <tjf@hector.10.80.10.9>  DramaDits version: 3.122
      
             ditsmonitor.c/DitsMonitorMsg(), The reply buffer for the forward
             monitor path set to 700x4 rather then 700x2.  This was needed
             for the Hector Detector to DRT case, where the tasks are running on
            different machines.  The Hector Detector task is using bulk data to transfer
            its data, which requires more space for messages then 700x2, but the monitor
            path is the one that is set up.
      
        ACMM ChangeLog: Fri Apr 30 14:51:34 2021 <tjf@aaolxp.aao.gov.au>  DramaDits version: 3.121
      
              Fix some comment spelling mistakes
      	Catch bad status on entry to Dits___MsgImpSys().
      
        ACMM ChangeLog: Wed Mar 17 13:57:26 2021 <mnb@aaolx133mbir.10.80.10.9>  DramaDits version: 3.120
      	Added last resort target %/libdits.a with recipe make libdits.a to
      	the GNUMakefile.am. This allows the intended command:
      		make libdits.a;
      	if the makefile is called with a full pathname eg:
      		make /Users/mnb/2dfdr/2dfdr_build/drama/DramaDits/libdits.a
      	which happens on the current catalina envirnments.
      	There should b eno other impact.
      
        ACMM ChangeLog: Wed Feb 17 09:09:52 2021 <tjf@aatliq.10.80.10.9>  DramaDits version: 3.119
      
              Remove DCONSTV qualifications from macro return values
      	   in DitsFix.h and DitsInteraction.h, they do nothing
      	   and gcc 9.3, C++ mode, is now complaining about them.
      
        ACMM Version 3.122.
      7356c02b
  5. 18 Jun, 2021 1 commit
  6. 17 Jun, 2021 1 commit
  7. 16 Jun, 2021 1 commit
  8. 04 Sep, 2020 1 commit
  9. 21 Aug, 2020 30 commits
    • Tony Farrell's avatar
      SEcond attempt at getting 2dfdr build to work · 0e543b08
      Tony Farrell authored and afarrell's avatar afarrell committed
              Second attempt at GNUMakefile.am
      0e543b08
    • Tony Farrell's avatar
      fix 2dfdr build issue and some other minor changes · 8fabf971
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Ensure GNUMakefile.am includes new ditsputact.c routine.
      
      	Fix commenting problems in ditsputact.c
      
      	Fix compiler warning in ticker.c
      
      	Change approach to disabling warning about fall through in case in
      	   duitoken.c, use the comment approach rather then the pragma.
      8fabf971
    • Tony Farrell's avatar
      More working on constent output for regression testing · b96ea389
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Changes needed to ctest.c to ensure the output is always consistent
              regardles sof machine performance.
      b96ea389
    • Tony Farrell's avatar
      Fix issue with test of sdptest.C · 65c54f06
      Tony Farrell authored and afarrell's avatar afarrell committed
             Fix issue in sdptest.C and don't output result which changes
             on different machines.
      65c54f06
    • Tony Farrell's avatar
      Testing issues with building on aatlxy · b79df58e
      Tony Farrell authored and afarrell's avatar afarrell committed
              Some of the testing diff commands don't work reliably due to
              things comming out in different orders.  Disabled for the
              moment.  Also the sdptest does not give the same results on
              32 bit and 64 bit machines which is not being handled
              correctly yet.
      b79df58e
    • Tony Farrell's avatar
      Fix issue in LISTACTALL command. Better regression testing · 888adec0
      Tony Farrell authored and afarrell's avatar afarrell committed
              LISTACTALL was listing overriden versions of actions, resolve that.
      
      	Add DitsIsRegTestMode() function, which returns true if the
      	    DRAMA_REG_TEST envrionment variable is defined.  This allows
      	    us to change the output of programs when running in regression
      	    test mode (e.g. don't output as much floating point precision).
      
      	dmakefile reworked to capture output of tests and run tests during
      	normal build.
      888adec0
    • Tony Farrell's avatar
      Support action descriptions Add DitsPutAction routine · 22ce689d
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Add DitsPutAction() routine - simplier way of adding one action.
      
      	Add support for action descriptions - via DitsPutActions(), new
      	    DitsPutAction() routine, DitsGetActDescr() routine and
      	    output by control messages.  Add DitsPutActDescr() and
      	    DitsPutThisActDescr() routines.
      22ce689d
    • Tony Farrell's avatar
      Fix gcc 8.3 warnings. Support DUL building ditscmd with DulLoadFacs call enabled · 5d902496
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Fix various warnings from gcc 8.3.  Included some string length
      	issues but only in test program, but most were about switch statement
      	fallthroughs (a comment is now required to this is delibrate, to
      	turn off the warning) and "const" returns which were unecessarry.
      
      	If ditscmd is built with the DUL_BUILD macro defined, then it
      	invokes DulLoadFacs().  The idea is that whilst ditscmd is by
      	default still part of this sub-system (which can't use DUL, that
      	is later in the build), DUL can rebuild it and re-release it with
      	this call enabled.  That will allow ditscmd to translate a much
      	larger set of error codes.
      5d902496
    • Tony Farrell's avatar
      ditscmd add q option. ditsgetinfo doesnt output bad status if just looking for... · 98050758
      Tony Farrell authored and afarrell's avatar afarrell committed
      ditscmd add q option. ditsgetinfo doesnt output bad status if just looking for a task which isnt there.
      
              In ditsgetinfo, If checking for a task running, don't output
              the unknown task error if it is not
              just return bad status.  This makes
              creating scripts which check for tasks running easier
      
              Add -q option to ditscmd, a parameter get which does not use MsgOut
                for output, instead just stdout, for use in scripts.
      
              ditscmd monitor operations now set the Send-Current flag, so the
                current values are seen on startup.
      98050758
    • Tony Farrell's avatar
      Deal with all warnings which appear with GCC 5.4 on linux · ee00f514
      Tony Farrell authored and afarrell's avatar afarrell committed
      	All warning now removed when compiled using GCC 5.4 on Linux, mainly
              through the use of DGCC_DIAG_OFF, but also sometimes through
      	appropiate casts.
      ee00f514
    • Tony Farrell's avatar
      Tasks command now outputs pid and machine name · d96fe820
      Tony Farrell authored and afarrell's avatar afarrell committed
      	tasks command now outputs pid and node name.
      d96fe820
    • Tony Farrell's avatar
      Add LISTACTALL and LISTACTACTIVE control messages. Add taskname to messages from DitsStop · 4cf00e3a
      Tony Farrell authored and afarrell's avatar afarrell committed
              Add LISTACTALL and LISTACTACTIVE control messages, simple versions
              of DUMPACTALL and DUMPACTACTIVE which just provide the action
              names.
      
      	DitsStop() ErsOut() calls now include the task name supplied to
      		   the call, which allows us to work out which task is
      		   outputting the message.
      4cf00e3a
    • Tony Farrell's avatar
      Improve logging around task disconnect and ensuring we return MACHLOST code... · b5f6ca5e
      Tony Farrell authored and afarrell's avatar afarrell committed
      Improve logging around task disconnect and ensuring we return MACHLOST code rather then TASKDISK when we have lost the machine
      
      	Improve logging around disconnection and machine lost messages as
      	part of trying to work out an AAO CCD system failure where unexplained
       	disconnections occur.   Basic approach is that if we have a logging
              routine, we log even if the relevant DITS_LOG_BASIC etc. flags are not
      	set.  These are rare events so won't dramatically increase the log size.
      
      	Note - now return DITS__MACHLOST status in cases where we used to
      	     return DITS__TASKDISC (which was a mistake).
      b5f6ca5e
    • Tony Farrell's avatar
      DitsLoad now catches a file name too longer for IMP to handle and gives a better error messages · 630581c0
      Tony Farrell authored and afarrell's avatar afarrell committed
      	If DitsLoad() is invoked with a program name greater then
      	IMP_MAX_PROG_NAME in length, then it fails immediately, as
      	some times the IMP failure can be hard to diagnoise.  Appropiate
      	error reporting suggesting the environment variable approach
      	is output.
      630581c0
    • Tony Farrell's avatar
      Fix issue in MsgOut being triggered by taipan · 0fbeaf25
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Fix issue in MsgOut() which was causing crashes if logging was
              enabled and we are in UFACE mode without an ufaceMsgOut routine
              enabled.  Picked up on taipan machine, maybe due to changes in
              compiler or libraries.
      0fbeaf25
    • Tony Farrell's avatar
      Improve error reporting around parameter monitor failures · 34b75375
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Better error reporting if we fail to fetch parameter names
      	setting up a monitor - the previous reporting made it hard
      	to work out what had failed, particular for a forward monitor.
      34b75375
    • Tony Farrell's avatar
      Add proper handling of trigger messages to ditscmd · 5e92f292
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Remove use of now depreciated ERS_M_NOFMT flag, using
      	either ERS___M___NOFMT or calling ErsRepNF(), depending on
      	the case.
      
      	ditscmd - Explicitly handle trigger messages so that we
                         can support -v for trigger messages and
                         improve the error output.
                        Import error handling for success argument
                         handling failures.
      5e92f292
    • Tony Farrell's avatar
      Change from linking mess.o to libmess.a · 93ffc33b
      Tony Farrell authored and afarrell's avatar afarrell committed
             dits_link.* modified to link libmess.a rather then mess.o
      93ffc33b
    • Tony Farrell's avatar
      IMP now allows workign through nat via IMP_LOCALNODE_FORCE, fix relevant message · b514543d
      Tony Farrell authored and afarrell's avatar afarrell committed
             I have modified IMP to work through NAT, so modify the message
              in the previous version to indicate what to do.  The requirement
              is that the system inside of the NAT environment must set the
              IMP_LOCALNODE_FORCE to the external IP address of the NAT
              router.
      b514543d
    • Tony Farrell's avatar
      Note NAT as possible cause of IMP__WRONG_MACHINE error code · e8359816
      Tony Farrell authored and afarrell's avatar afarrell committed
      	IMP__WRONG_MACHINE messages can be triggered by an attempt to run DRAMA
               through a NAT (Network Address Translation) system.  This doesn't work
               as IMP presumes the IP address of the machine on the other side of the
               NAT system is reachable.
      e8359816
    • Tony Farrell's avatar
      Fix some MacOSX Mavericks warnings. Add macro to allow user to work out if... · b0ec2c2d
      Tony Farrell authored and afarrell's avatar afarrell committed
      Fix some MacOSX Mavericks warnings. Add macro to allow user to work out if DRAMA_REA_DRAMA2 available
      
      	Add DITS_HAVE_REA_DRAMA2 macro to DitsTypes.h, so that code comiling against
      	both old and new DRAMA code and work out what to do with DITS_REA_DRAMA2.
      
      	Fix various compilaing warnings using DGCC_DIAG_OFF()/DGCC_DIAG_ON() macros.
      b0ec2c2d
    • Tony Farrell's avatar
      Fix logging flaws to allow working better with DRAMA2 · 2a653630
      Tony Farrell authored and afarrell's avatar afarrell committed
      	DitsStop() writes its log message using Dits___Log() rather
      		   then DitsLog(), to keep it consistent with other
      				internal logging.
      
      	ditsexhand_ux.c  logs under different conditions, consistent
      		with mods to DitsStop().
      2a653630
    • Tony Farrell's avatar
      Add support needed by Drama2. Fix bulk data trigger messages · 5ce3ce68
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Add routines DitsTransIdLock() and DitsTransIdUnlocked() to ensure
      	    a transaction is not reused too soon (by DRAMA2).
      
      	Bulk data triggers were not getting through, and have not been
      	     for years - due to a check in Dits___MsgTap() against the
      	     message tag - which has a confusing usage for Bulk data
      	     trigger messages.  Set the value to 0 when Dits___MsgTap() is
      	     invoked for bulk data messages, which disables the check.
      5ce3ce68
    • Tony Farrell's avatar
      Create DitsUfaceMsgOut. Fix some logging messages · 8ada8f80
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Modify DitsMsgWait() logging - don't need to output time.
      
      	Add DitsUfaceMsgOut(), and use it to implement Dits___UfaceInfoMess().
      	This allows DitsUfaceMsgOut() to be invoked from the DRAMA2 Orphan
      	  handler.
      8ada8f80
    • Tony Farrell's avatar
      Fix MacOsX mavericks CLang compile issues · eadde090
      Tony Farrell authored and afarrell's avatar afarrell committed
      	sdptest.C, ditsloadcmd.c, ditsutil.c, dui.c, tocker.c, btocker.c
      		tock_sdstest.c, ticker.c, ctest.c, ctest3.c.
      
      		Fix warnings detected by MacOsX mavericks, mainly uninitialised
      		variables, but some others as well.
      eadde090
    • Tony Farrell's avatar
      Add DitsSignalDrama2 and DramaSignalExit to support Drama2 · 8ec3f4ea
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Add DitsSignalDrama2(), such that we have a special signal for
      	    use by DRAMA 2 thread events.  DitsGetEntReason() will return
      	    the new code of DITS_REA_DRAMA2.  This will allow us to distinguish
      	    user triggered signals from thread completion signals.
      
      	Add DitsSignalExit(), a special signal which causes the mainloop to
      	    exit.
      8ec3f4ea
    • Tony Farrell's avatar
      Improved logging around shutdown · 0c2f5038
      Tony Farrell authored and afarrell's avatar afarrell committed
      	DitsStop will now log a shutdown message with status.
      0c2f5038
    • Tony Farrell's avatar
      Moinor change to last change · 69bc4bcf
      Tony Farrell authored and afarrell's avatar afarrell committed
             Modification to VxWorks version of last chage, don't stop option
             processing after task name seen, people have been using that.
      69bc4bcf
    • Tony Farrell's avatar
      Document double dash option to ditscmd, add w option · 8bbee64f
      Tony Farrell authored and afarrell's avatar afarrell committed
              ditscmd.c Changes. Add -- option to VxWorks version (already exists
      		  in unix (via getopt()).  Document  -- option in help.
      		  Add -w option.
      
      	Fix some compilation warnings picked up by later GCC.
      8bbee64f
    • Tony Farrell's avatar
      Remove call to nanosleep under VxWorks from tea.c · 326644e4
      Tony Farrell authored and afarrell's avatar afarrell committed
      	Removed call to nanosleep under VxWorks in tea.c.
      326644e4